Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify workflow #96

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Simplify workflow #96

merged 3 commits into from
Sep 7, 2021

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented Sep 7, 2021

@CAMOBAP CAMOBAP force-pushed the feature/simplify-workflow branch 3 times, most recently from 019350a to bfc4568 Compare September 7, 2021 14:05
@CAMOBAP CAMOBAP marked this pull request as ready for review September 7, 2021 14:24
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Sep 7, 2021

@ronaldtse @Intelligent2013 could you please review my changes:

  • workflow simplified
  • fontist instead platform dependent packages

Open question is that ok that our java on GitHub Packages has 0 downloads? https://github.com/metanorma/mn2pdf/packages/898794

P.S. add votes for badges/shields#4183

@ronaldtse
Copy link
Contributor

Open question is that ok that our java on GitHub Packages has 0 downloads?

Because we don't use mn2pdf outside the mn2pdf-ruby gem...

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Sep 7, 2021

@ronaldtse right! thanks for explanation

@CAMOBAP CAMOBAP self-assigned this Sep 7, 2021
@ronaldtse
Copy link
Contributor

Awesome work here, thanks @CAMOBAP !

@ronaldtse ronaldtse merged commit 6894527 into main Sep 7, 2021
@ronaldtse ronaldtse deleted the feature/simplify-workflow branch September 7, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

@Intelligent2013 Intelligent2013 Awaiting requested review from Intelligent2013

Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAMOBAP @ronaldtse