Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept mentions not working in non-Clause 3 of a vocabulary document #939

Closed
ronaldtse opened this issue Nov 9, 2024 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Nov 9, 2024

From

Errors:

AsciiDoc Input: (ID _dbf283e5-cf07-41c4-9817-aa688d118490): Error: Term reference to `iCalendar` missing: "iCalendar" is not defined in document
AsciiDoc Input: (ID _cf734446-6bbb-429b-9ec7-fdf4f4d08d4c): Error: Term reference to `iCalendar` missing: "iCalendar" is not defined in document
AsciiDoc Input: (ID _c421fa9e-3ef1-402e-8958-d68831912851): Error: Term reference to `vCard` missing: "vCard" is not defined in document

And this also causes metanorma-ietf to crash (metanorma/metanorma-ietf#213).

The way to work with vocabulary documents is documented here:

[heading=terms and definitions]
== Terms related to specific technologies

=== Calendar data formats

==== iCalendar
standard format for representing calendar data

[.source]
<<cc_glossary>>

==== vCalendar
legacy format for calendar data superseded by {{iCalendar}}

[.source]
<<cc_glossary>>

==== vCard
standard format for representing contact information

[.source]
<<cc_glossary>>

==== xCal
XML representation of {{iCalendar}} data

[.source]
<<cc_glossary>>

==== xCard
XML representation of {{vCard}} data
@ronaldtse ronaldtse added the bug Something isn't working label Nov 9, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma Nov 9, 2024
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Nov 9, 2024
@opoudjis
Copy link
Contributor

opoudjis commented Nov 9, 2024

Going to CalConnect/cc-calendar-vocab#3

The error is different: the terms are not being recognised as terms at all:

<clause id="_terms_related_to_specific_technologies" obligation="normative">
<title>Terms related to specific technologies</title>
<clause id="_calendar_data_formats" obligation="normative">
<title>Calendar data formats</title>
<clause id="_icalendar" obligation="normative">
<title>iCalendar</title>
<p id="_f659ec5d-98f0-a569-e214-ae67c6afbc49">standard format for representing calendar data</p>

That is because Metanorma has inherited from ISO the constraint that there is only one Terms and Definitions section per document, outside of ISO/IEC vocabulary documents; and 03-22-misc.adoc is marked up as a distinct sister clause to the Terms and Definitions clause, not a subclause of it.

If I comment out that bit:

//[heading=terms and definitions]
//== Terms related to specific technologies

The concepts process fine, because the "Calendar data formats" are recognised as terms fine.

So we have two alternatives:

  • In CC, mark "Terms related to specific technologies" up as a subclause of the Terms (include::03-22-misc.adoc[leveloffset=+1]), because CC doesn't know about vocabulary documents, and the Metanorma constraint that there can be only one Terms section per document is good and needs to be preempted in markup
  • The Metanorma constraint that there can be only one Terms section per document is only advisory, and if the user puts in a heading attribute wanting there to be two in the document, that should be respected, for any flavour of Metanorma

@ronaldtse Which do you want?

@opoudjis opoudjis moved this from 🌋 Urgent to 👀 In review in Metanorma Nov 9, 2024
@ronaldtse
Copy link
Contributor Author

Given that vocabulary documents are quite widespread amongst SDOs, perhaps it is easier if we relax the "one terms section only per document" rule.

For this particular document, I am planning to also cross-publish to ISO as a proper vocabulary document, so I prefer keeping the same structure across documents.

@opoudjis opoudjis moved this from 👀 In review to 🏗 In progress in Metanorma Nov 10, 2024
@opoudjis
Copy link
Contributor

Removing the blanket "only one of these clauses per document" restriction if the clause type is specified as a heading attribute.

opoudjis added a commit to metanorma/metanorma.org that referenced this issue Nov 10, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Metanorma Nov 10, 2024
@opoudjis
Copy link
Contributor

These errors have gone away with the fix to standoc, as the clause is now recognised as a second terms clause.

We now have a different error: isodoc still is expecting to find a single terms section, so the second term section is not getting any anchors processed for it.

@opoudjis opoudjis reopened this Nov 10, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Metanorma Nov 10, 2024
@opoudjis
Copy link
Contributor

Explicitly allowing multiple terms & definitions clauses in the isodoc clause_order module

opoudjis added a commit to metanorma/isodoc that referenced this issue Nov 10, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Metanorma Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants