-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document attributes for cover and back page image #227
Comments
The document JIS Z 8301 for testing purposes: https://github.com/metanorma/mn-samples-jis/pull/48
|
Coverpage images have been implemented for BSI, ITU, and Plateau. Rather than implement them separately for JIS, I am going to implement them across Metanorma.
So the solution I'm going to generalise to all of Metanorma is that of BSI, which encompasses the rest. |
Because this is refactoring some code, @Intelligent2013, you'll need to pull standoc, iso, and jis. I'm pushing to main and breaking it, because release is Monday. |
@Intelligent2013 Please confirm this is working. |
Remove cover images from relaton grammars, they are only temporarily put there, and end up instead in metanorma-extension. |
@opoudjis unfortunately in the generated presentation XML there aren't element The document: https://github.com/metanorma/mn-samples-jis/pull/48 (branch:
|
hello @opoudjis i noticed in the discussion above "coverpage" and "Plateau" here; a quick question: is there, or could there be, control over the fonts designated for use in the cover page, if they were different than what are used in the body of the document? see rp/ribose_discussions#19 |
@ReesePlews cover-page images are "per-document" settings where the font is a "per-flavor" setting. The font used on a flavor's coverpage is currently determined by code. It is understandable that the font on different documents of the same flavor are the same for consistency reasons. |
@Intelligent2013 It's working fine, but you need to also include
So:
I have been forced to remove Noto JP fonts, which were crashing compilation. |
@opoudjis no effect. My
Well, looks like something wrong in my environment or Metanorma installation. I've tried to generate the PDF and displayed mn2pdf command line contains
It may occurs due the old jis xslt. I didn't merge it yet. |
I understood the problem. But not the solution. There are two
When I run |
@Intelligent2013 this means the "bundle exec metanorma" command is using the wrong metanorma executable. It should use the bundled version instead of the choco version. This seems like a PATH problem? |
@ronaldtse @Intelligent2013 looks the same to me, it looks like the chocolatey's bin is appeared before gem's bin for some reason One of the solutions is to call metanorma by a full path |
@ronaldtse @CAMOBAP you are right.
The path Thank you! |
@opoudjis sorry, looks like I've closed your ticket. |
No, it was for you to close, you've confirmed it's now working as expected. |
Source issue: #226
Add parameters:
:coverpage-image:
- image location, for image to be included on the PDF cover page. Image location is relative to the source document.:backpage-image:
- same, for image to be included on the PDF back page.See similar parameters in https://www.metanorma.org/author/bsi/ref/document-attributes/.
Currently I think don't need to support comma-delimited list images, one image is enough.
The text was updated successfully, but these errors were encountered: