Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IPAM master branch from prow config #246

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Remove IPAM master branch from prow config #246

merged 1 commit into from
Oct 15, 2021

Conversation

kashifest
Copy link
Member

Now that main is the default branch, prow should not be tracking master branch anymore.

@kashifest
Remove IPAM master branch from prow config
88ab136 
Now that main is the default branch, prow should not be tracking master branch anymore
@kashifest
Copy link
Member Author

/test-integration

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2021
fmuyassarov
fmuyassarov reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
namnx228
namnx228 reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@namnx228 namnx228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kashifest kashifest mentioned this pull request Oct 15, 2021
Closed
furkatgofurov7
furkatgofurov7 reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit b4f5367 into metal3-io:master Oct 15, 2021
@metal3-io-bot
Copy link
Collaborator

@kashifest: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

Now that main is the default branch, prow should not be tracking master branch anymore.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest kashifest deleted the remove/ipam-master-branch branch October 15, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@fmuyassarov fmuyassarov fmuyassarov left review comments

@namnx228 namnx228 namnx228 left review comments

@Rozzii Rozzii Rozzii approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kashifest @metal3-io-bot @namnx228 @Rozzii @fmuyassarov @furkatgofurov7