Fix kustomize v5.4.1 sha value #1395
Conversation
metal3-io-bot
added
the
size/XS
|
/test metal3-centos-e2e-integration-test-release-1-7 |
|
/test metal3-ubuntu-e2e-integration-test-main |
|
/test metal3-ubuntu-e2e-integration-test-main |
|
/test ? |
|
@Sunnatillo: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test dev-env-integration-test-centos-release-1-5 |
| @@ -343,7 +343,7 @@ export KREW_SHA256="${KREW_SHA256:-5df32eaa0e888a2566439c4ccb2ef3a3e6e89522f2f21 | |||
|
|
|||
| # Kustomize version | |||
| export KUSTOMIZE_VERSION="${KUSTOMIZE_VERSION:-v5.4.1}" | |||
| export KUSTOMIZE_SHA256="${KUSTOMIZE_SHA256:-29e4c003b5b22fd017e0da0f71ce0a4ceb7bfd1dec338f0b505b341f087499c8}" | |||
| export KUSTOMIZE_SHA256="${KUSTOMIZE_SHA256:-3d659a80398658d4fec4ec4ca184b432afa1d86451a60be63ca6e14311fc1c42}" | |||
There was a problem hiding this comment.
wait, how did the PR went in if the sha was not matching ?
There was a problem hiding this comment.
That is a wonder for me as well
There was a problem hiding this comment.
Quicly checked the tests run on kustomize uplift PR.
download_and_install_kustomize function did not run on those tests.
There was a problem hiding this comment.
I know now whats the issue, we only check in those functions if the binary exists, we dont check if the binary has the intended version or not, it was the same with minikube which I fixed at some point, I will send a fix for kustomize.
/approve
|
/test dev-env-integration-test-centos-release-1-5 |
|
/test dev-env-integration-test-centos-main |
|
@Sunnatillo: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Sunnatillo <[email protected]>
Sunnatillo
force-pushed
the
fix-kustomize-sha256/sunnat
branch
from
0b598fc
to
3750b4c
Compare
metal3-io-bot
added
the
approved
|
Overriding the following required tests, They were already passed on this PR. |
|
@smoshiur1237: Overrode contexts on behalf of smoshiur1237: metal3-centos-e2e-integration-test-release-1-7, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sunnatillo
changed the title
Fixes kustomize checksum value in dev env