Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Make deep image inspection configurable #603

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Dec 12, 2024

This PR:

  • Implements the support for disabling the deep_image_inspection via environment variable.

This new functionality is needed because e.g right now the Ironic&IPA has issues running deep image inspection on e.g. live-iso images.

This commit:
  - Implements the support for disabling the deep_image_inspection via
    environment variable.

This new functionality is needed because e.g right now the Ironic&IPA has
issues running deep image inspection on e.g. live-iso images.

Signed-off-by: Adam Rozman <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 12, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@Rozzii
Copy link
Member Author

Rozzii commented Dec 12, 2024

Related BMO Issue: metal3-io/baremetal-operator#2110

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We need this so we can remove the pinning of ironic to 26.0 in BMO, and can keep testing Ironic main. We also need this backported to 27.0 where the deep inspection issue is also happening.

/cherry-pick release-27.0

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 16, 2024

/cc @iurygregory @elfosardo

@tuminoid
Copy link
Member

/cherry-pick release-27.0
Wake up bot.

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-27.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-27.0
Wake up bot.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

/cc @elfosardo @dtantsur

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@metal3-io-bot metal3-io-bot merged commit 656d90c into metal3-io:main Dec 16, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the disable_deep_img_inspection branch December 16, 2024 10:36
@metal3-io-bot metal3-io-bot added this to the ironic-image - v27.0 milestone Dec 16, 2024
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #604

In response to this:

/cherry-pick release-27.0
Wake up bot.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants