-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Make deep image inspection configurable #603
✨ Make deep image inspection configurable #603
Conversation
This commit: - Implements the support for disabling the deep_image_inspection via environment variable. This new functionality is needed because e.g right now the Ironic&IPA has issues running deep image inspection on e.g. live-iso images. Signed-off-by: Adam Rozman <[email protected]>
/test metal3-centos-e2e-integration-test-main |
Related BMO Issue: metal3-io/baremetal-operator#2110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We need this so we can remove the pinning of ironic to 26.0 in BMO, and can keep testing Ironic main. We also need this backported to 27.0 where the deep inspection issue is also happening.
/cherry-pick release-27.0
/cherry-pick release-27.0 |
@tuminoid: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @elfosardo @dtantsur |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tuminoid: new pull request created: #604 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR:
This new functionality is needed because e.g right now the Ironic&IPA has issues running deep image inspection on e.g. live-iso images.