Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cert-manager to v0.11.1 in Tiltfile and scripts #928

Closed
furkatgofurov7 opened this issue Apr 17, 2023 · 3 comments · Fixed by #932
Closed

Bump cert-manager to v0.11.1 in Tiltfile and scripts #928

furkatgofurov7 opened this issue Apr 17, 2023 · 3 comments · Fixed by #932
Assignees
@zhouhao3
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@furkatgofurov7
Copy link
Member

Detailed Description

cert-manager version in the provider is pretty old and we need to update it. New cert manager version is available (https://github.com/cert-manager/cert-manager/releases) so let's use it.

Anything else you would like to add:

CAPI already uses newest cert-manager version (v0.11.1) in main/release-1.4/release-1.3 branches so once merged we can also back-port it to relevant provider release branches.

/kind feature
@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 17, 2023
@furkatgofurov7
Copy link
Member Author

/triage accepted
/good-first-issue

@metal3-io-bot
Copy link
Contributor

@furkatgofurov7:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 17, 2023
@zhouhao3
Copy link
Member

/assign

@zhouhao3 zhouhao3 mentioned this issue Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouhao3 zhouhao3

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Bump cert-manager to v1.11.1 zhouhao3/cluster-api-provider-metal3
3 participants
@zhouhao3 @furkatgofurov7 @metal3-io-bot