This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
Makefile: Add kubeubilder and kustomize checks. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
reviewed
May 23, 2019
Makefile
Outdated
| .PHONY: testprereqs | ||
| testprereqs: | ||
| @if [ ! -d /usr/local/kubebuilder ] ; then echo "kubebuilder not found. See docs/dev/setup.md" && exit 1 ; fi | ||
| @if ! which kustomize >/dev/null 2>&1 ; then echo "kustomize not found. See docs/dev/setup.md" && exit 1 ; fi |
There was a problem hiding this comment.
We could "go get" kustomize, couldn't we?
There was a problem hiding this comment.
We could.
Right now docs/dev/setup.md points you to tools/install_kustomize.sh which we had because we required an older release of kustomize. That's not true anymore so it could be all dropped in favor of go get.
There was a problem hiding this comment.
pushed another patch which does this
|
Based on the failure, it looks like $PWD for the job in travis isn't the top of the repo? |
russellb
force-pushed
the
kubebuilder-req
branch
2 times, most recently
from
d1c2ce4 to
1f6cb89
Compare
Generating manifests and running the test suite require kustomize and kubebuilder. Add a quick check for them to the Makefile to avoid less obvious errors later if they are missing. Closes issue metal3-io#14.
I had removed that file, but missed that it was used in the travis-ci config |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating manifests and running the test suite require kustomize and
kubebuilder. Add a quick check for them to the Makefile to avoid less
obvious errors later if they are missing.
Closes issue #14.