Skip to content
This repository has been archived by the owner on Mar 24, 2020. It is now read-only.

Research Machine selection when scaling down a MachineSet #10

Closed
russellb opened this issue Feb 26, 2019 · 4 comments
Closed

Research Machine selection when scaling down a MachineSet #10

russellb opened this issue Feb 26, 2019 · 4 comments
Assignees
@russellb

Comments

@russellb
Copy link
Member

When a MachineSet is scaled down, we may have additional criteria to help chose which Machine is the most appropriate one to Delete. We should determine what the current logic is, and if we should introduce some additional functionality where we can influence which Machine is chosen.
@mhrivnak
Copy link
Member

mhrivnak commented Apr 2, 2019

This PR merged, which adds the ability to annotate a machine to signify that it's the one you want to delete.

kubernetes-sigs/cluster-api#726

russellb pushed a commit to russellb/cluster-api-provider-baremetal that referenced this issue Apr 10, 2019
@openshift-merge-robot
Merge pull request metal3-io#10 from russellb/openshift-rebase
4f84dc0 
Merge latest from metalkube/cluster-api-provider-baremetal
@russellb
Copy link
Member Author

We still need to update our cluster-api fork to include that change

@russellb russellb self-assigned this May 13, 2019
@russellb
Copy link
Member Author

merged cluster-api-update PR

@russellb
Copy link
Member Author

russellb commented May 22, 2019 •
edited
Loading

note the key bit about selecting a Machine for deletion when scaling down a MachineSet:

Simple delete policy has been modified to select a Machine for scale down with the annotation machineset.clusters.k8s.io/delete-me=yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@russellb russellb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhrivnak @russellb