-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add unit test for LoadAuth funciton in auth.go #1774
Conversation
228736f
to
936d116
Compare
/cc @lentzi90 @kashifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The code looks good!
Could you please squash the commits?
/approve
/hold
(for squashing)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
936d116
to
a53b825
Compare
a53b825
to
0e39b3d
Compare
@lentzi90 : commits are squashed. |
/ok-to-test |
099c374
to
aa5b24b
Compare
@kashifest : the DCO and the lint issues are solved. |
Yes please squash always |
Thanks. ideally yes squashed with a proper commit message would be helpful |
aa5b24b
to
1b8d1d5
Compare
Signed-off-by: babugeet <[email protected]>
1b8d1d5
to
7767a23
Compare
@lentzi90 , @kashifest : addressed all comments. Pls check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
What this PR does / why we need it:
This PR adds unit test for LoadAuth funciton, mentioned in the issue #1574
Which issue(s) this PR fixes:
Fixes # #1574
The provided test cases cover the following scenarios for the LoadAuth function: