Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump go to v1.21.7 #1584

Merged

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Mar 4, 2024

Golang 1.20 is out of support in Feb 2024. Bumping golang image only in dockerfile, but not go.mod because it will break library consumers.

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024
@Sunnatillo Sunnatillo changed the base branch from main to release-0.5 March 4, 2024 12:07
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024
@Sunnatillo Sunnatillo changed the title 🌱 Bump go to v1.21.17 sunnat 🌱 Bump go to v1.21.17 Mar 4, 2024
@Sunnatillo Sunnatillo force-pushed the uplift-go-to-v1.21.17-sunnat branch from 79313ae to cfa6c6b Compare March 4, 2024 12:15
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

/retitle 🌱 Bump go to v1.21.7

@metal3-io-bot metal3-io-bot changed the title 🌱 Bump go to v1.21.17 🌱 Bump go to v1.21.7 Mar 4, 2024
@Sunnatillo Sunnatillo force-pushed the uplift-go-to-v1.21.17-sunnat branch from cfa6c6b to b5a21d3 Compare March 4, 2024 12:18
Makefile Outdated Show resolved Hide resolved
hack/e2e/ensure_go.sh Outdated Show resolved Hide resolved
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

Please put in proper description.

@Sunnatillo Sunnatillo force-pushed the uplift-go-to-v1.21.17-sunnat branch from b5a21d3 to 9728acf Compare March 4, 2024 12:22
@Sunnatillo
Copy link
Member Author

Please put in proper description.

done

@Sunnatillo
Copy link
Member Author

/metal3-bmo-e2e-test-pull

Signed-off-by: Sunnatillo <[email protected]>
@Sunnatillo Sunnatillo force-pushed the uplift-go-to-v1.21.17-sunnat branch from 9728acf to a675d2d Compare March 4, 2024 12:33
@Sunnatillo
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@Sunnatillo
Copy link
Member Author

/test-ubuntu-integration-release-1-6
/test-centos-e2e-integration-release-1-6

@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

Cherry-pick #1586 should fix the BMO e2e issue.

@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

/test markdownlint

@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

/retest
If this still fails, you need to rebase @Sunnatillo.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@metal3-io-bot metal3-io-bot merged commit 3c7516c into metal3-io:release-0.5 Mar 4, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the uplift-go-to-v1.21.17-sunnat branch March 4, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants