Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Workaround issue with minikube image load #1572

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Mar 1, 2024

What this PR does / why we need it:

There is a bug in the new docker release that affects minikube image load. While we wait for a new minikube release, we can work around the issue by exporting the image to an archive and load it from there instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Mar 1, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member Author

lentzi90 commented Mar 1, 2024

I guess this will fail though...
/test-centos-e2e-integration-main

@kashifest
Copy link
Member

/override test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

There is a bug in the new docker release that affects minikube image
load. While we wait for a new minikube release, we can work around the
issue by exporting the image to an archive and load it from there
instead.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-minikube-load branch from c57bd1d to 0233902 Compare March 1, 2024 07:01
@lentzi90
Copy link
Member Author

lentzi90 commented Mar 1, 2024

/test metal3-bmo-e2e-test-pull

@kashifest
Copy link
Member

/override test-centos-e2e-integration-main
/approve

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@metal3-io-bot metal3-io-bot merged commit b5c4120 into metal3-io:main Mar 1, 2024
18 of 19 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/e2e-minikube-load branch March 1, 2024 07:28
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

/cherry-pick release-0.5
This is needed in 0.5 branch as well.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1586

In response to this:

/cherry-pick release-0.5
This is needed in 0.5 branch as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants