Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics endpoint has port conflict #252

Closed
hardys opened this issue Jul 9, 2019 · 0 comments · Fixed by #253 or openshift/baremetal-operator#29
Closed

metrics endpoint has port conflict #252

hardys opened this issue Jul 9, 2019 · 0 comments · Fixed by #253 or openshift/baremetal-operator#29

Comments

@hardys
Copy link
Member

hardys commented Jul 9, 2019

Since fa1d0e1 landed I'm seeing #212 and openshift-metal3/dev-scripts#635 fail starting the BMO like:

$ oc logs metal3-baremetal-operator-58b4c4d558-q28ll -c baremetal-operator --namespace openshift-machine-api
{"level":"error","ts":1562673586.4834816,"logger":"cmd","msg":"","error":"error listening on 127.0.0.1:8080: listen tcp 127.0.0.1:8080: bind: address already in use","stacktrace":"github.com/metal3-io/baremetal-operator/vendor/github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/src/github.com/metal3-io/baremetal-operator/vendor/github.com/go-logr/zapr/zapr.go:128\nmain.main\n\t/go/src/github.com/metal3-io/baremetal-operator/cmd/manager/main.go:73\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:198"}

So we need to either configure a different port in that environment, or choose a new default here I think?
hardys pushed a commit to hardys/baremetal-operator that referenced this issue Jul 9, 2019
Avoid port conflict for metrics endpoint
010527b 
In the OpenShift integrated case this conflicts with coredns which binds
to :::8080, switching to 8085 should avoid this conflict with the
default.

Fixes: metal3-io#252
@hardys hardys mentioned this issue Jul 9, 2019
Merged
dhellmann pushed a commit to dhellmann/baremetal-operator that referenced this issue Jul 26, 2019
@dhellmann
Avoid port conflict for metrics endpoint
48a1030 
In the OpenShift integrated case this conflicts with coredns which binds
to :::8080, switching to 8085 should avoid this conflict with the
default.

Fixes: metal3-io#252
@dhellmann dhellmann mentioned this issue Jul 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@hardys