Adjust logic on bmh controller

- we no longer need the currentError stored, since we don't clear
  the ErrorType before calling Service.
- include dirty when changing the Status.Provisioning.Firmware, this
  is to ensure we would run an actionUpdate.

Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>

controllers/metal3.io/baremetalhost_controller.go

@@ -1402,14 +1402,13 @@ func (r *BareMetalHostReconciler) doServiceIfNeeded(prov provisioner.Provisioner
 	// succeed before leaving this state (e.g. by deprovisioning) we lose the signal that the
 	// update didn't actually happen. This is deemed an acceptable risk for the moment since it is only
 	// going to impact a small subset of Firmware Settings implementations.
-	currentError := info.host.Status.ErrorType
 	if info.host.Status.OperationalStatus != metal3api.OperationalStatusServicing {
 		info.host.Status.OperationalStatus = metal3api.OperationalStatusServicing
 		return actionUpdate{}
 	}
 
 	provResult, started, err := prov.Service(servicingData, dirty,
-		currentError == metal3api.ServicingError)
+		info.host.Status.ErrorType == metal3api.ServicingError)
 	if err != nil {
 		return actionError{fmt.Errorf("error servicing host: %w", err)}
 	}
@@ -1424,6 +1423,7 @@ func (r *BareMetalHostReconciler) doServiceIfNeeded(prov provisioner.Provisioner
 
 	if started && fwDirty {
 		info.host.Status.Provisioning.Firmware = info.host.Spec.Firmware.DeepCopy()
+		dirty = true
 	}
 
 	if provResult.Dirty {