Skip to content

Commit

Permalink
Adjusted the timing of setting servicing status and clearing errors.
Browse files Browse the repository at this point in the history
Signed-off-by: Jacob Anders <[email protected]>
  • Loading branch information
rhjanders authored and iurygregory committed Nov 7, 2024
1 parent 55ec006 commit dedd3a2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions controllers/metal3.io/baremetalhost_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -1407,6 +1407,11 @@ func (r *BareMetalHostReconciler) doServiceIfNeeded(prov provisioner.Provisioner
// update didn't actually happen. This is deemed an acceptable risk for the moment since it is only
// going to impact a small subset of Firmware Settings implementations.
currentError := info.host.Status.ErrorType
if info.host.Status.OperationalStatus != metal3api.OperationalStatusServicing {
info.host.Status.OperationalStatus = metal3api.OperationalStatusServicing
return actionUpdate{}
}

provResult, started, err := prov.Service(servicingData, dirty,
currentError == metal3api.ServicingError)
if err != nil {
Expand Down

0 comments on commit dedd3a2

Please sign in to comment.