Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metaljs.com for use with Electric v3.0.0 #361

Closed
wants to merge 1 commit into from

Conversation

robframpton
Copy link

No description provided.

@zenorocha
Copy link
Contributor

Friendly ping @jbalsas.

@jbalsas
Copy link
Contributor

jbalsas commented Mar 9, 2018

Hey @zenorocha, thanks for the ping! I took a look the other day, but when testing, I saw this in the tutorials section:

screen shot 2018-03-09 at 09 14 45

I haven't had time to take a closer look, though :(

It's likely caused by some marble styling, I guess, so I'm not sure if that affects other places, so we should fix it in general, or just customize on top for this site.

screen shot 2018-03-09 at 09 17 11

@jbalsas
Copy link
Contributor

jbalsas commented Mar 9, 2018

The contribute section was also off, both in this PR and in current Marble, probably since we moved the repos around:

Metal points to an archived repo, and the github icon is not centered, not sure if that's a similar case that with the tutorial links and this affects elsewhere or needs some change?
screen shot 2018-03-09 at 09 18 57

Marble points to a deleted repo, so it returns a 404
screen shot 2018-03-09 at 09 19 11

@jbalsas
Copy link
Contributor

jbalsas commented Mar 9, 2018

@diegonvs
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@diegonvs
Copy link
Contributor

Hey guys, i've continued at #369

@jbalsas
Copy link
Contributor

jbalsas commented Mar 27, 2018

Cool!

@jbalsas jbalsas closed this Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants