Rename AuthenticateSubject to ValidateCredential #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuthenticateSubject is sort of a clunky name for what this RPC actually does, which is validating credentials. This commit renames it to ValidateCredential and updates the response with subject_id as a field returned directly instead of arbitrary claims (inspired by SPIFFE, which has similar APIs). This is a breaking change. Signed-off-by: John Schaeffer <[email protected]>
mikemrm
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthenticateSubjectis sort of a clunky name for what theAuthenticateSubjectRPC actually does, which is validating credentials. This PR renames it toValidateCredentialand updates the response withsubject_idas a field returned directly instead of arbitrary claims (inspired by SPIFFE, which has similar APIs).This is a breaking change.