Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade go from 1.21.0 to 1.20 #11

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

Alva8756
Copy link
Collaborator

Downgrade the Go version from 1.21.0 to 1.20.

Reasons:

  1. Keep it consistent as ConditionOrc
  2. mtcl lint uses 1.20
  3. Upgrading versions in mtcl causes dependency errors. It may be more straightforward to downgrade the version of the BomService instead of upgrading mctl.

@Alva8756 Alva8756 requested review from a team and removed request for a team September 19, 2023 00:12
@Alva8756 Alva8756 merged commit 04ebec3 into metal-toolbox:main Sep 19, 2023
1 check passed
@DoctorVin
Copy link
Contributor

I think the issue is that the tooling is unhappy locking the last digit of the version? I’m not 100% clear on what the second error in the trace was.

@joelrebel
Copy link
Member

This comment hints to the possible cause - golang/go#61851 (comment)

It might just be the CodeQL env that needs to be updated

"/opt/hostedtoolcache/CodeQL/2.14.5/x64/codeql/go/tools/autobuild.sh". Exit code was 1 and error was: 2023/09/18 23:58:42 Autobuilder was built with go1.20.7, environment has go1.20.8

@Alva8756 Alva8756 deleted the downgrade_go_version branch October 26, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants