Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy http example resource to GitHub repo #172

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Jun 10, 2024

Thus we have more control over the data.

See #170.

Thus we have more control over the data.
@dr0i dr0i requested a review from TobiasNx June 10, 2024 13:43
@dr0i dr0i added the documentation Improvements or additions to documentation label Jun 10, 2024
@dr0i
Copy link
Member Author

dr0i commented Jun 10, 2024

@TobiasNx could you have a look. This PR shows how we can build a more stable base for documentation - consider all data at the web in the hand of others (publishers!) as volatile. So we should create our own test data resp. copy that bit. Just by copying the data into this repo. Trying to condense the data that is needed and remove superflous data so we don't bloat our repo too much, if possible.

@dr0i
Copy link
Member Author

dr0i commented Jun 10, 2024

(note to self: don't forget to update the data path when merging to master).

@dr0i dr0i mentioned this pull request Jun 10, 2024
This was linked to issues Sep 2, 2024
This was unlinked from issues Sep 2, 2024
@TobiasNx
Copy link
Contributor

@dr0i +1 from me, do we need to look trough all the tests?

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Sep 23, 2024
@dr0i
Copy link
Member Author

dr0i commented Sep 23, 2024

Yes, that is the idea.
If you don't have time to do it atm we also could merge this and come to it later when the need arises.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Sep 23, 2024
@TobiasNx TobiasNx merged commit b69aed6 into main Nov 29, 2024
2 checks passed
@TobiasNx TobiasNx deleted the 169-copyHttpExamplesToGithubRepo branch November 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants