-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change set_
-functions behaviour to not create intermediate structures.
#309
Comments
The aspect of the intermediate structure seems to be true for all fixes of the PS: The new functions |
The are a copy of the current implementation of set_array and set_hash. This is a preparation for #309
As a preliminary work for #309 since set_array will change its behaviour but add_array will keep the functionality.
As a preliminary work for #309 since set_array will change its behaviour but add_array will keep the functionality.
Also wenn the behaviour change is implemented we should rename all set_ tests to add_ ones as well as add new set functions. |
set_field()
behaviour to not create intermediate structures.set_
-functions behaviour to not create intermediate structures.
With the upcoming releases the behaviour of set_ will change so that no intermediate structure will be created. To prepare for this change we will use the add_ version of these functions. See the following issue for further info: metafacture/metafacture-fix#309
add_field()
andset_field()
are going to be equivalent with #308, but according to Catmandu's documentationset_field()
"will not create the intermediate structures if they are missing".Functional review: @TobiasNx
Code review: @blackwinter / @fsteeg
The text was updated successfully, but these errors were encountered: