-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating new arrays with $append
/$prepend
#127
Comments
Will revisit after #102. Functional review: @TobiasNx |
$append
/$prepend
Since this is standard behaviour of Catmandu fix I would like when this gets prioritized over other fix tickets. |
It seems that this would "only" need adjustment in two code segments, but I could be wrong: metafacture-fix/metafix/src/main/java/org/metafacture/metafix/FixPath.java Lines 173 to 175 in 5561729
metafacture-fix/metafix/src/main/java/org/metafacture/metafix/FixPath.java Lines 342 to 345 in 5561729
|
Ready for functional review in branch |
Changes in PR should be done, could you test again with current branch |
I tried lobid-resources and all tests did run trough without changes +1 |
If we want to support the behaviour for creating an array with index number we should revisit this test and change it.
We should reintroduce $append and $prepend as creation methods if the array does not exist in a record to add to or create an array.
Was part of: #111
Related to: #93 and #92
The text was updated successfully, but these errors were encountered: