Fix "batch-reset creates empty records" #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
functional review : @TobiasNx (see #543 (comment) for a useful |
blackwinter
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Please don't add failing tests. Every commit should pass on its own.
Either introduce the tests along with their fix, or add tests showing the wrong behaviour (including a comment to that effect) and then fix them later along with the implementation.
Note that we introduced the @MetafixToDo annotation in metafacture-fix for exactly this purpose (see metafacture/metafacture-fix#158).
metafacture-io/src/test/java/org/metafacture/io/ObjectFileWriterTest.java
Show resolved
Hide resolved
metafacture-io/src/test/java/org/metafacture/io/ObjectFileWriterTest.java
Outdated
Show resolved
Hide resolved
By not calling the pipe (aka wrapper) but the receiver directly the stream is only once resetted when called once. (In conjunction with ObjectFileWriter and StreamBatchResetter this bug had resulted in as many empty files as non-empty ones.)
dr0i
force-pushed
the
543-fixBatchResetCreatesEmptyRecords
branch
from
16b9349
to
3724a99
Compare
dr0i
force-pushed
the
543-fixBatchResetCreatesEmptyRecords
branch
from
3724a99
to
d3a47ee
Compare
TobiasNx
added a commit
to TobiasNx/notWorkingFlux
that referenced
this pull request
Oct 2, 2024
metafacture/metafacture-core#560 Commit-Hash: d3a47eeb70166d1ffe66ffd1cf7f3926dbc89c4d
TobiasNx
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543.