Permit URL! to be converted to TUPLE! #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PARSE of a URL! in the network code was capturing a range out of the content in order to locate the host name. If it were numeric as in `tcp://93.184.216.34` the host name would be converted TO TUPLE! to signify it was an IP-address. This was not working, because R3-Alpha would only convert STRING! and the bug went unnoticed because the conversion was inside of an ATTEMPT. This changes to accept URL! as the "easy fix", but adds notes on the matter for deeper consideration.
The routine Qualify_String had a cryptic name, and some instances would comment what it did...warning readers that it could raise errors and that the buffer it returned was temporary. Those two facts were much more important in the name than "Qualify" or even "String", so this renames it to `Temp_Byte_Chars_May_Fail` and expands upon the comments for the reason for its existence. There were also several hardcoded constants used with this routine to make buffers such that they would align with the maximum length of a scanned input for a type. This puts all those numbers together as constants in sys-scan.h so that they may be considered (in particular, how necessary it is to try and codify such limits for these conversions, as it seems error-prone to keep in sync with the scanner if new notations arise.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PARSE of a URL! in the network code was capturing a range out of
the content in order to locate the host name. If it were numeric as in
tcp://93.184.216.34the host name would be converted TO TUPLE!to signify it was an IP-address.
This was not working, because R3-Alpha would only convert STRING!
and the bug went unnoticed because the conversion was inside of
an ATTEMPT. This changes to accept URL! as the "easy fix", but
adds notes on the matter for deeper consideration.
(Another commit in this PR updates Qualify_String's name and corrals
some hardcoded constants.)