-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Xbox controller; introduce Takeover policy w/o brake #615
Conversation
@QuanyiLi could you play with |
[BOT] Great job! You have changed the docstring coverage from 30.54% to 30.54%, improving 0.005%. |
It feels bad when the car drives fast. At least, my performance degrades. Maybe I overfit the old keyboard controller... |
It takes so long for the steering wheel to return to the center. It makes the control hard when the speed is high. |
[BOT] Great job! You have changed the docstring coverage from 30.54% to 30.54%, improving 0.005%. |
Now I've reverted all values to previous version. The key differences:
If throttle > 0, and you press elif throttle_brake < 0.: # WHEN YOU PRESS DOWN KEY
self.throttle_brake = min(self.throttle_brake, 0.) # IF throttle>0, IT WILL SET TO 0.
self.throttle_brake -= self.BRAKE_INCREMENT # throttle NOW EQUALS brake_increment Instead, in this impl, we use: elif down_key_pressed:
if self.throttle_brake <= 0.0:
self.throttle_brake -= self.BRAKE_INCREMENT
else:
self.throttle_brake -= self.BRAKE_INCREMENT_WHEN_THROTTLE note that BRAKE_INCREMENT = 0.5 In this impl, we avoid too large change in the note: when I say press down, I say press |
[BOT] Great job! You have changed the docstring coverage from 30.54% to 30.54%, improving 0.005%. |
It is good now. |
[BOT] Great job! You have changed the docstring coverage from 30.54% to 30.55%, improving 0.012%. |
[BOT] Great job! You have changed the docstring coverage from 30.54% to 30.55%, improving 0.012%. |
[BOT] Great job! You have changed the docstring coverage from 30.54% to 30.55%, improving 0.012%. |
What changes do you make in this PR?
Checklist
bash scripts/format.sh
before merging.