-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps (2024-05) #3280
Merged
Merged
Update deps (2024-05) #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
update-deps-2024-05
branch
from
May 28, 2024 15:57
27ff7dc
to
a9930ca
Compare
This also gets rid of a version mismatch warning between the two (it worked anyway, but still).
querystring is deprecated, but it turns out the only code that used it is dead code since 2022 (with 09154b8) so it can be dropped entirely.
reosarevok
force-pushed
the
update-deps-2024-05
branch
from
May 28, 2024 17:20
a9930ca
to
0d7b6c7
Compare
https://github.com/sindresorhus/file-url says: Node.js supports this built-in now with url.pathToFileURL(path).
reosarevok
force-pushed
the
update-deps-2024-05
branch
from
May 28, 2024 19:06
0d7b6c7
to
f6a235e
Compare
reosarevok
force-pushed
the
update-deps-2024-05
branch
4 times, most recently
from
May 30, 2024 08:25
ddea5c2
to
86eeef0
Compare
reosarevok
force-pushed
the
update-deps-2024-05
branch
from
May 30, 2024 14:55
86eeef0
to
3a1a8e2
Compare
reosarevok
force-pushed
the
update-deps-2024-05
branch
from
May 30, 2024 15:34
3a1a8e2
to
aec0562
Compare
mwiencek
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I was able to get Selenium tests running on this branch fine.
This was mostly abandoned, so I forked it for now and converted it to ESM so it will keep working with the latest, ESM only version of gettext-parser.
Versions above this break with doubly escaped comments such as #~| which weblate uses with fuzzy matching. smhg/gettext-parser#79
reosarevok
force-pushed
the
update-deps-2024-05
branch
from
June 4, 2024 16:25
aec0562
to
9bf0af0
Compare
rm yarn.lock && yarn
mwiencek
force-pushed
the
update-deps-2024-05
branch
from
June 4, 2024 16:35
155d27b
to
1430429
Compare
@brainzbot, retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating most of our deps that can be updated (some of which hadn't been touched for years).