-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBS-13117: Prevent localizing admin-only messages #3091
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 12cb746 - Browse repository at this point
Copy the full SHA 12cb746View commit details -
Skip extracting messages from non-module files
There is no non-module file **.pl under lib/ anyway, but even if there was any it would be for admin only.
Configuration menu - View commit details
-
Copy full SHA for 2c52f68 - Browse repository at this point
Copy the full SHA 2c52f68View commit details -
Add ((t)exp.)l[np]_admin for admin messages
Implement all eventually needed functions to prevent translating messages destinated to admin in both admin and non-admin pages, as part of MBS-13117.
Configuration menu - View commit details
-
Copy full SHA for 2fd5dcc - Browse repository at this point
Copy the full SHA 2fd5dccView commit details -
Use l_admin as appropriate in non-admin pages
Prevent translating messages destinated to admin in non-admin pages, as part of MBS-13117.
Configuration menu - View commit details
-
Copy full SHA for 1b18529 - Browse repository at this point
Copy the full SHA 1b18529View commit details -
Use exp.l_admin in admin-only pages
It is equivalent to expand2react(cleanMsgid) but it makes it explicit that it is intentionally to not translate messages destinated to admin, as part of MBS-13117.
Configuration menu - View commit details
-
Copy full SHA for e5567d3 - Browse repository at this point
Copy the full SHA e5567d3View commit details -
Test in CI that admin pages avoid localization
To prevent any further accidental localization in admin pages, this patch makes CI tests to exit with error with a non-empty list of lines calling localization functions (l, ln, lp, N_l, N_ln, N_lp).
Configuration menu - View commit details
-
Copy full SHA for 983dd5d - Browse repository at this point
Copy the full SHA 983dd5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c23d62 - Browse repository at this point
Copy the full SHA 3c23d62View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f425e - Browse repository at this point
Copy the full SHA e3f425eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05960f8 - Browse repository at this point
Copy the full SHA 05960f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae72a3a - Browse repository at this point
Copy the full SHA ae72a3aView commit details -
Drop unused and useless lp_admin
There will never be any context needed for not translatable messages.
Configuration menu - View commit details
-
Copy full SHA for 4e7fdb3 - Browse repository at this point
Copy the full SHA 4e7fdb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e2e74e - Browse repository at this point
Copy the full SHA 7e2e74eView commit details
Commits on Dec 5, 2023
-
Preserve some messages after commit 05960f8
The column labels for languages and scripts were exposed to admins only but still translated. These messages would be removed from translations after the previous commit 05960f8 from the following files: - root/admin/attributes/Attribute.js - root/admin/attributes/Language.js - root/admin/attributes/Script.js However those will likely be needed again after resolving MBS-11178. This patch preserves column labels and their translations by temporarily defining these in a unused file until MBS-11178 gets resolved.
Configuration menu - View commit details
-
Copy full SHA for e76ec04 - Browse repository at this point
Copy the full SHA e76ec04View commit details