Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-11178: Make attribute lists visible to all users #2480

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

MBS-11178: Make attribute lists visible to all users #2480

wants to merge 7 commits into from

Commits on Sep 18, 2024

  1. Clarify function names 

    The attributes are rendered in Attribute, these are only
a few extra headers/columns for some types.
    @reosarevok
    reosarevok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    13b9765 View commit details
    Browse the repository at this point in the history

  2. MBS-11178: Make attribute lists visible to all users 

    This removes the info that is mostly useless for people without
editing rights (such as edit links) but displays everything else.

Row ids are not removed since documenting these on the site
is apparently helpful for people putting together SQL queries
(this has been requested).

Since this is visible to users, translations are brought back.
    @reosarevok
    reosarevok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e9c211f View commit details
    Browse the repository at this point in the history

  3. Move generic attributes form to the same folder as others 

    This seems a lot more consistent than having them in two places.
    @reosarevok
    reosarevok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f1cf9dd View commit details
    Browse the repository at this point in the history

  4. Move attributes code out of admin folders 

    Since this is no longer admin-only, there's no reason
all of this should live inside /admin folders.

Use l_admin for admin-facing strings only.
    @reosarevok
    reosarevok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2b7e000 View commit details
    Browse the repository at this point in the history

  5. Generalize attribute layout 

    This reduces code reuse to some degree.
We could make further changes to also generalize
part of the tables for each model, but I'm not sure it's worth
the effort.
Additionally, this shows a proper translatable title
for each attribute type, since we'll display them to users now.
Only Language and Script were translated before.
    @reosarevok
    reosarevok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ad0c088 View commit details
    Browse the repository at this point in the history

  6. Make list of attribute types more usable 

    This splits the list in two, one for entity types and one
for everything else.
It also sorts them by the (translated) names of the attribute types,
rather than by the static model name.
    @reosarevok
    reosarevok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    610a7d8 View commit details
    Browse the repository at this point in the history

  7. Rename attributes/Index to AttributesList 

    This is not the index for an attribute, it's the list of all attributes.
Consistent with RelationshipTypesList for reltypes.
    @reosarevok
    reosarevok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    28105a6 View commit details
    Browse the repository at this point in the history