Port RecentListens to Typescript #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramsingh
reviewed
Apr 11, 2020
paramsingh
reviewed
Apr 11, 2020
ishaanshah
force-pushed
the
recent-listen-port
branch
2 times, most recently
from
c699938
to
ff4d969
Compare
ishaanshah
changed the title
ishaanshah
commented
Apr 12, 2020
ishaanshah
force-pushed
the
recent-listen-port
branch
from
ce7d0fc
to
24e0fe5
Compare
ishaanshah
commented
Apr 12, 2020
| @@ -141,7 +141,6 @@ export default class SpotifyPlayer extends React.Component< | |||
| } | |||
| this.handleWarning("Could not find track on Spotify"); | |||
| this.playNextTrack(); | |||
| return; | |||
There was a problem hiding this comment.
Extra return statements, removed by the linter. I checked if player was working as expected and the alert bug didn't appear. This should be safe to remove.
paramsingh
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're moving over to Typescript for our frontend code. This pull request migrates the profile.jsx file to typescript.
We also do some linting fixes here.
Problem
The LB frontend code is very hard to read or modify because it's complex and javascript provides no guarantee of what is available where etc.
Solution
Use typescript instead, which helps us have types on react components and functions and catch errors at compile time.
The linter has also caught a few actual bugs too.