Fix cover art in release card component #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts commit 5e9d882 , thte CAA was down at the time so I didn't realize how this change impacted the component, which now does not show any image
Needed to force the aspect ratio and fit-content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 5e9d882 I made a big mistake, changing a display value to fix a sizing issue but not realizing it resulted in hiding the cover art entirely (at the time I was coding #2997 the cover art archive was down so I could not have realized the issue).
This PR reverts the offending change, and resolves the issue it was trying to solve, but using a different approach that doesn't end up hiding the cover art... 🤦