Support macOS for downloading #637
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS doesn't have an `md5check` command, so we need to execute the `md5` command for each file separately. The Linux path should act the same as before.
facebook-github-bot
added
the
CLA Signed
Add a more obvious place for people to paste in their URL (if they want to edit the script) Sanity check the URL before proceeding Provide earlier feedback when large files are being checksumed
The .py script should be executable, while the README should not
|
I've added extra parts to allow downloads to be continued. |
|
Picking this review up, I'm also looking at similar #727 |
|
This PR is behind main, and also incorporates some changes in behaviors not included in the description (such as removing the prompting for URL). This PR may need some additional work before it's mergeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS doesn't have an
md5checkcommand, so we need to execute themd5command for each file separately. The Linux path should act the same as before.