Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#minor); CI/CD; Add capability to deploy only and add action to test builds on pushing to the remote branched in this repo. #879

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

steegecs
Copy link
Collaborator

@steegecs steegecs commented Aug 25, 2022

Context:

  • There have been many instances where subgraphs fail to deploy upon merging into the master repository. This has often been due to build failing for various reasons at the time of merge. We wanted to add the capability to build only in the script, and test the builds on pushing to the repo before merging.
  • These changes will require an update to the deployment.js and execution.js files in the deployment folder, the creation of a new action, and updating the npm deploy script in each subgraph folder to include a new parameter for specifying the action (just building or deploying.)

@steegecs steegecs marked this pull request as ready for review August 25, 2022 17:46
.github/workflows/build-checker.yaml Outdated Show resolved Hide resolved
.github/workflows/build-checker.yaml Show resolved Hide resolved
deployment/execution.js Show resolved Hide resolved
subgraphs/uniswap-forks/configurations/configure.ts Outdated Show resolved Hide resolved
deployment/deployment.js Outdated Show resolved Hide resolved
@jaimehgb
Copy link
Collaborator

Looking good! Eager to see it live :D

Left a few minor suggestions, and the comment about the action issue which might be the only really important thing

@steegecs steegecs marked this pull request as draft August 26, 2022 14:50
@steegecs steegecs marked this pull request as ready for review August 29, 2022 13:38
jaimehgb
jaimehgb previously approved these changes Aug 29, 2022
@this-username-is-taken
Copy link
Contributor

Amazing work!

@this-username-is-taken this-username-is-taken merged commit 5c0f556 into messari:master Aug 30, 2022
@this-username-is-taken this-username-is-taken deleted the steegecs/cicd branch August 30, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants