Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#major); EtherFi; Add Subgraph #2554

Merged
merged 11 commits into from
Jun 6, 2024

Conversation

harsh9200
Copy link
Collaborator

@harsh9200 harsh9200 commented May 28, 2024

Summary

Adds subgraph for EtherFi on Ethereum using generic schema.

Test Deployment: https://subgraphs.messari.io/subgraph?endpoint=QmURUkHMqEDGLi36JTssmWLgdYeDipEUvD1G1FgLTdjBrz&tab=protocol

Preliminary QA

TVL

image
image

Supply Side Revenue

image

Protocol Side Revenue

image

Daily Active Users

image

@steegecs steegecs self-requested a review June 3, 2024 13:26
Copy link
Collaborator

@steegecs steegecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-06-03 at 9 26 35 AM

Looks good. Can you explain to me the spikey revenues? Most days they are 0.

@harsh9200
Copy link
Collaborator Author

@steegecs The revenues are calculated using the WithdrawFunds function call on the EtherFiNode contract. This function can be either used to do a partial withdrawal (claim only the staking rewards) or a full withdrawal (complete withdrawal of principal amount plus the accumulated rewards). This huge spike in revenue is because we are also calculating the principal amount in full withdrawal as revenue. I have pushed a fix to remove the principal amount from the revenue calculation.

New Deployment: https://subgraphs.messari.io/subgraph?endpoint=QmURUkHMqEDGLi36JTssmWLgdYeDipEUvD1G1FgLTdjBrz&tab=protocol

@steegecs steegecs self-requested a review June 6, 2024 01:19
Copy link
Collaborator

@steegecs steegecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harsh9200 harsh9200 merged commit b957541 into messari:master Jun 6, 2024
4 checks passed
@harsh9200 harsh9200 deleted the harsh9200/etherfi-subgraph branch June 6, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants