-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#patch); venus; handle proxy contracts update #2454
fix(#patch); venus; handle proxy contracts update #2454
Conversation
dhruv-chauhan
commented
Jan 15, 2024
- Issues:
- missing markets
- deposits not being recorded
- These issues are due to updated implementations for proxy Comproller and VToken equivalent contracts.
- Deployments:
- (grafted) https://okgraph.xyz/?q=dhruv-chauhan%2Fvenus-protocol-bsc
- (complete) https://okgraph.xyz/?q=dhruv-chauhan%2Fvenus-protocol-bsc-2
- Note:
- grafted deployment fixed missing markets, lists new markets for UNI and FDUSD and records deposit events for them
- for capturing mint (deposit) events older markets like BTC, we will have to wait for complete syncing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruv-chauhan I think I am confused how this change is going to fix the issue..?
- You create the template for Ctoken and VtokenV2 for each and every market
- and the events
Mint()
andRedeem()
point to the same function twice
- Wouldn't the event signature be different and not even work for
handleMint
for the V2 contract?
If you look at what I did in compound V2:
CTokenOld.create(event.params.cToken); |
What do you think of this? Maybe I am wrong
I think that's necessary, and should not be much overhead. I'm assuming
Yes, the signatures will be different, but it works in this case since the event.params we are using inside the handlers are common for both signatures. |
I see, yeah I think I was getting confused bc comp v2 does not change the abi after it has been deployed. It simply just as a new abi for newer markets. So this seems like an accurate fix. As for the question about using the same function for both ABIs, to me that is kind of confusing. But, it is not a huge deal. In an effort to not add more indexing time, I think we can leave it as is. Approving, but make sure to fix the prettier stuff before merging :) |
da04b8a
to
a35ebed
Compare
d1d8edb
to
0393bbb
Compare
Not sure why prettier is still failing. Failing check is passing fine for me,
|
@dhruv-chauhan I get the same thing. We can merge this to unblock for now |