Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#major); abracadabra; subgraph optimizations #2446

Merged

Conversation

dhruv-chauhan
Copy link
Collaborator

@dhruv-chauhan dhruv-chauhan commented Dec 19, 2023

  • Huge arrays in abracadabra-money-avalanche deployment causing issues for other subgraphs in the shard.
  • As a suggested storage optimization, we looked to convert large arrays (length>50) as @derivedFrom mappings, but on querying it looks like the larger arrays already follow this convention, others do not need to due to very small length. Reference query; schema.
  • Since most of these large arrays are snapshots and events, we could further make these entities immutable.
  • Changed ID fields from strings to Bytes.
  • Test deployment: https://okgraph.xyz/?q=dhruv-chauhan%2Fabracadabra-money-avalanche

@dhruv-chauhan dhruv-chauhan marked this pull request as ready for review December 19, 2023 19:01
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm and the schema looks good. Just want to confirm the comment I made. If the IDs change at all we have assumptions downstream that need to be coordinated

subgraphs/abracadabra/schema.graphql Outdated Show resolved Hide resolved
@dhruv-chauhan dhruv-chauhan merged commit 9ad3f98 into messari:master Jan 6, 2024
4 checks passed
@dhruv-chauhan dhruv-chauhan deleted the abracadabra-optimizations branch January 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants