Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#minor); aave v2 forks; missing liquidation data #2412

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

melotik
Copy link
Contributor

@melotik melotik commented Oct 26, 2023

#2411 - The issue is that v2 markets do not have any liquidation data
#2414

Solution: V2 markets do not have a liquidation protocol fee, and the subgraph was early returning when that occured on liquidation calls.

A V3 to ensure it still works:

V2 Subgraphs:

@melotik melotik requested a review from dhruv-chauhan October 26, 2023 21:09
@melotik melotik marked this pull request as draft October 26, 2023 21:09
@melotik melotik marked this pull request as ready for review October 27, 2023 19:25
Copy link
Collaborator

@dhruv-chauhan dhruv-chauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@melotik melotik merged commit 9a0d430 into messari:master Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants