Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#patch); bancor-v3; add other possible stable target tokens for tradeOutputBySourceAmount #2371

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix(#patch); bancor-v3; add other possible stable target tokens for tradeOutputBySourceAmount #2371

merged 2 commits into from
Sep 15, 2023

Conversation

dhruv-chauhan
Copy link
Collaborator

@dhruv-chauhan dhruv-chauhan commented Sep 14, 2023 •
edited
Loading

@dhruv-chauhan dhruv-chauhan linked an issue Sep 14, 2023 that may be closed by this pull request
Bancor-V3 Ethereum: No pricing for swaps #2367
Closed
melotik
melotik approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great header comment, super clear what is going on! change lgtm

@dhruv-chauhan dhruv-chauhan merged commit b9ae9ba into messari:master Sep 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melotik melotik melotik approved these changes

@bye43 bye43 Awaiting requested review from bye43

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bancor-V3 Ethereum: No pricing for swaps
2 participants
@dhruv-chauhan @melotik