feat(#major); kwenta; new subgraph

[amritkumarj]

Deployment link : https://thegraph.com/hosted-service/subgraph/amritkumarj/kwenta-optimism

[ishraq8]

this version with tvl passed QA

[melotik]

@amritkumarj a few notes before a deeper PR:

• I notice there are a lot of files/functions that are unused. These should be removed to simplify the code and make the review smaller
• The SDK should cover a lot of the code
• My comments are a starting place, I do see some more things that are unused
• Can you add the deployment link to the header comment in the PR

Thank you!

[dhruv-chauhan]

As @dmelotik mentioned, you don't really need most files in src/common and src/utils since these are included in the sdk

[dhruv-chauhan]

also, please fix lint errors 😃

[amritkumarj]

Hey @dhruv-chauhan

I think there is some confusion between working of kwenta and gmx

In gmx the collateral is deposited when we are opening the position, and when we close the position we receive the collateral back in our account

But this is not the case with kwenta - we first deposit collateral i.e. sUSD for all markets and then we open any position, and on close just the collateral value is increased, which can be withdrawn by the user in a different transaction

And there are no liquidity pools in Kwenta like GMX

So, I think instead of "deposit()" and "withdraw()" in "handleMarginTransferred" we should use collateral in and out, and not use these functions in "handlePositionModified"

And "deposit()" & "withdraw()" function should be removed as they are for liquidity pools

What do you think?

[dhruv-chauhan]

If I understand correctly,

1. User deposits sUSD as liquidity to a sTOKENPERP [handleMarginTransferred]
2. Opens a position with part of deposited sUSD as collateral [handlePositionModified]
   ...
3. Closes position, gets back collateral [handlePositionModified]
4. Exits market, withdraws liquidity [handleMarginTransferred]

So imo,
deposit/withdraw of liquidity in handleMarginTransferred and,
collateralIn/collateralOut of trading collateral in handlePositionModified works fine as currently implemented.

@ishraq8 can overrule

[ishraq8]

he case with kwenta - we first deposit collateral i.e. sUSD for all markets and then we open any position, and on close just the collateral value is increased, which can be withdrawn by the user in a different transaction

This makes sense. sUSD becomes the collateral instead of other input tokens.

[amritkumarj]

This makes sense. sUSD becomes the collateral instead of other input tokens.

Yes, sUSD is used as collateral but what I wanted to say is there is no withdrawal or deposit of collateral at time of positionModified that got me into some confusion

But I think what @dhruv-chauhan said makes sense and fixed the issues according to his solution

[dhruv-chauhan]

Overall the code looks good. 🤙

Some of the data looks a little odd to me, but I'll leave verification for QA. Example,

• (derivPerpProtocols) longPositionCount ~ 19k vs shortPositionCount ~ 200
• (derivPerpProtocols) cumulativeInflowVolume ~ 4.7b vs cumulativeOutflowVolume ~ 470m

** Needs to be fixed,

• (usageMetricsDailySnapshots) dailyActiveLiquidators > cumulativeUniqueLiquidators query

cc @ishraq8

[ishraq8]

Data looks good and passed QA.

looks like the longpositioncount and shortpositioncount makes sense long is preferred positions. The short and long open interest seem similar in value which is where matching really matters.

Cumulative inflow will always be greater than outflow as the protocol relies on higher inflow. if it is reveresed it indicates there is a bankrun or unhealthy protocol (kwenta is quite healthy).

[dhruv-chauhan]

** Needs to be fixed,

• (usageMetricsDailySnapshots) dailyActiveLiquidators > cumulativeUniqueLiquidators query

Hey @amritkumarj, if you could just fix cumulativeUniqueLiquidators/dailyActiveLiquidators calculations, we'd be ready to merge the PR!

[amritkumarj]

Fixed it in the new commit

This issue is also present in gmx - query

[dhruv-chauhan]

Great work, thank you!