fix(#patch); Uniswap Forks; Upgrade Pricing Mechanism #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content:
The purpose of this PR is to upgrade the pricing mechanism to utilize the same constraints as the new Uniswap V3 pricing mechanism that we implemented from insights gained in the recent investigation into pricing anomalies on DEXs.
3 Changes were made:
In addition to these changes, I made some changes to the code to pass the event to the token getter. This was done so that I could modify the token pricing so that it occurs at the time the token is retrieved from the store. I incremented all versions for the Uniswap Forks as this change will impact all protocols.
This PR is outlined in issue #2036.