Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError When Deleting Nested Data #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zabakala
Copy link

Hi. I just ran into an issue when trying to delete nested data.

vuex1
vuex2

Properly resolving the import from Firestore resolved the issue. Thx beforehand for taking a look at this PR.

@mesqueeb
Copy link
Owner

This is an issue when there are two different versions of firebase I believe.

1 similar comment
@mesqueeb
Copy link
Owner

This is an issue when there are two different versions of firebase I believe.

@zabakala
Copy link
Author

zabakala commented Apr 19, 2023

Yop, it could be. It is in line with the repo´s package.json, i.e. "firebase": "^9.0.0". In this particular erroneous case of mine, the imported one is firebase": "9.9.2", i.e. not 10 or onwards. But the imported /compat variant is to ensure correct functionality.

@zabakala
Copy link
Author

@mesqueeb Hi. Is there a probability of merging in either this one or anything else leading to the resolution of this reported issue? We have, for the time being, resorted to using a forked version of the repo with the fix included, but we would like to switch back to the original one.

@mesqueeb
Copy link
Owner

@zabakala I'm just not sure this is the correct fix. I'm dependency injecting the firebase instance IIRC. So there must be something going wrong somewhere else perhaps. I will try and have a look this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants