Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 2094 Enable the ability to clear environment variables #163

Closed
wants to merge 2 commits into from

Conversation

aldipower
Copy link
Contributor

I should be able to clear the a row by pressing on the "-"-button, if there is only 1 row left, because I maybe want to remove my env vars completely. Of course the row line stays, but empty.

Before:
row1
After pressing on each "-":
row2

Fixes d2iq-archive/marathon#2094

@aldipower
Copy link
Contributor Author

Should be merged into #158 before.

@aldipower aldipower changed the title Fix/2094 remove env Fix: 2094 Enable the ability to clear environment variables Aug 28, 2015
@philipnrmn
Copy link
Contributor

This behaviour was deliberately introduced in PR #162. It was requested to address some usability issues in the modal: d2iq-archive/marathon#950 (comment)

decrease opacity to 50% on the "(–)" icon when editing the last remaining row of a duplicable set of values (disabled state)

@aldipower
Copy link
Contributor Author

This behavior prevents the user from removing the last environment variable, so this would stay forever, even if not needed anymore.

@philipnrmn
Copy link
Contributor

I agree it would be nice to be able to clear the last value by using a 'reset' button.

Dimming the ⊖ button but leaving it enabled seems really confusing.

@aldipower
Copy link
Contributor Author

Yes, so don't dimm.

@philipnrmn
Copy link
Contributor

In that case shouldn't we just revert 9e83115 rather than merging this PR?

@aldipower
Copy link
Contributor Author

Ok, if you know how to do this, it's the cleaner way.. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants