Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rebuild karma image to bring back TLS server name support #1809

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

mikolajb
Copy link
Contributor

@mikolajb mikolajb commented Jan 3, 2024

What problem does this PR solve?:

Rebuild an image to keep it compatible with the existing configuration: https://nutanix.slack.com/archives/C066Z6Q0C2H/p1704282760071239?thread_ts=1704231984.117689&cid=C066Z6Q0C2H

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mikolajb mikolajb self-assigned this Jan 3, 2024
@github-actions github-actions bot added services/karma size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2024
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7396943005

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 7389026374: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@mikolajb mikolajb force-pushed the mikolajb/karma-image branch from 054e2ae to 44a352c Compare January 3, 2024 11:57
@mikolajb mikolajb requested a review from gracedo January 3, 2024 12:09
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Bring it back

@palexster palexster added ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo backport-to-release-2.7 backport-pr This is a backport PR and removed backport-pr This is a backport PR labels Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/mikolajb/karma-image

@mikolajb mikolajb merged commit 60450dd into main Jan 3, 2024
41 of 44 checks passed
@mikolajb mikolajb deleted the mikolajb/karma-image branch January 3, 2024 16:25
mikolajb added a commit that referenced this pull request Jan 3, 2024
mikolajb added a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-release-2.7 ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/karma size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants