feat(koperator): Remove pre-upgrade job to set kcore version #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracedo
added
ready-for-review
ok-to-test
github-actions
bot
added
the
size/L
|
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
Pull Request Test Coverage Report for Build 6514905293
💛 - Coveralls |
cwyl02
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
I noticed that the koperator pre-upgrade job was failing due to insufficient perms
Error from server (Forbidden): kommandercores.dkp.d2iq.io "kommander-core" is forbidden: User "system:serviceaccount:kommander:kommander-operator-pre-upgrade" cannot get resource "kommandercores/status" in API group "dkp.d2iq.io" at the cluster scopeHowever, I realized that since we will not be shipping the declarative upgrade feature in full in the next release, we don't need this pre-upgrade job at all to update existing kcore statuses with the current version. We can instead just let the operator treat it as it would a "fresh install" which is to update the status with the current version and exit without running the upgrade workflow steps that we have added so far.
Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-99516
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist