Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kommander-karma] [kommander-thanos] Add secret reloader annotations #443

Merged

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Feb 19, 2020

https://jira.d2iq.com/browse/D2IQ-64099
Uses the new option in mtls-proxy to add secret reloader annotations to the proxy deployment (federated addon).

The following needs to be done (with #438 merge):

  1. Bump the version of mtls-proxy used in kommander-thanos and kommander-karma and add the secret.reloader.stakater.com/reload annotations ✅ DONE IN THIS PR
  2. Bump the deps of kommander-thanos and kommander-karma in kommander chart to pull in the latest changes from the above
  3. Bump kommander version in kubeaddons-kommander

Testing

I tested this manually by hosting mtls-proxy, kommander-thanos, kommander-karma, and kommander charts on my personal GH. I konvoy up on addons version master, then upgraded the kommander chart by deploying addons with my kubeaddons-kommander branch gracedo/bug_certs_D2IQ-64099.

  - configRepository: https://github.com/mesosphere/kubeaddons-kommander
    #configVersion: master
    configVersion: gracedo/bug_certs_D2IQ-64099
    addonsList:
    - name: kommander
      enabled: true

Upon upgrading, I verified that updated secrets were federated out to the managed clusters (as they were before) then checked that the proxies now had the reloader annotation:
image
image

I checked Thanos and Karma UIs in the kommander cluster and saw that they were still able to connect to the proxies even after upgrading
image
image

@gracedo gracedo added the ready ready label Feb 19, 2020
@gracedo gracedo requested a review from a team as a code owner February 19, 2020 16:08
@gracedo gracedo self-assigned this Feb 19, 2020
shaneutt
shaneutt previously approved these changes Feb 19, 2020
samvantran
samvantran previously approved these changes Feb 19, 2020
branden
branden previously approved these changes Feb 19, 2020
alejandroEsc
alejandroEsc previously approved these changes Feb 19, 2020
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@alejandroEsc
Copy link
Contributor

lint error

18:01:52][Step 1/2] 2020/02/19 18:01:52 [INFO] Missing required value: thanos address must be set
[18:01:52][Step 1/2] Error linting charts: Error processing charts
[18:01:52][Step 1/2] ------------------------------------------------------------------------------------------------------------------------
[18:01:52][Step 1/2]  ✖︎ kommander-karma => (version: "0.3.4", path: "stable/kommander-karma") > Error waiting for process: exit status 1
[18:01:52][Step 1/2]  ✔︎ kommander-thanos => (version: "0.1.9", path: "stable/kommander-thanos")
[18:01:52][Step 1/2] ------------------------------------------------------------------------------------------------------------------------

Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the lint issue, lgtm!

Copy link
Contributor

@GoelDeepak GoelDeepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alejandroEsc alejandroEsc merged commit 4c6ce44 into mesosphere:master Feb 19, 2020
mesosphere-teamcity pushed a commit that referenced this pull request Feb 19, 2020
…443)  * kommander-karma: Add secret reloaded annotation to mtls-proxy FederatedAddon  * kommander-thanos: Add secret reloaded annotation to mtls-proxy FederatedAddon  * kommander-karma: Fix template var  Co-authored-by: Alejandro Escobar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants