-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kommander-karma] [kommander-thanos] Add secret reloader annotations #443
[kommander-karma] [kommander-thanos] Add secret reloader annotations #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
lint error
|
14575d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the lint issue, lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…443) * kommander-karma: Add secret reloaded annotation to mtls-proxy FederatedAddon * kommander-thanos: Add secret reloaded annotation to mtls-proxy FederatedAddon * kommander-karma: Fix template var Co-authored-by: Alejandro Escobar <[email protected]>
https://jira.d2iq.com/browse/D2IQ-64099
Uses the new option in
mtls-proxy
to add secret reloader annotations to the proxy deployment (federated addon).The following needs to be done (with #438 merge):
mtls-proxy
used inkommander-thanos
andkommander-karma
and add thesecret.reloader.stakater.com/reload
annotations ✅ DONE IN THIS PRkommander-thanos
andkommander-karma
inkommander
chart to pull in the latest changes from the abovekubeaddons-kommander
Testing
I tested this manually by hosting
mtls-proxy
,kommander-thanos
,kommander-karma
, andkommander charts
on my personal GH. Ikonvoy up
on addons versionmaster
, then upgraded the kommander chart by deploying addons with mykubeaddons-kommander
branchgracedo/bug_certs_D2IQ-64099
.Upon upgrading, I verified that updated secrets were federated out to the managed clusters (as they were before) then checked that the proxies now had the reloader annotation:
I checked Thanos and Karma UIs in the kommander cluster and saw that they were still able to connect to the proxies even after upgrading