azuredisk: bump version to 0.5.0 #394
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,10 +20,11 @@ spec: | |
| priorityClassName: system-cluster-critical | ||
| containers: | ||
| - name: csi-provisioner | ||
| image: "{{ .Values.image.csiProvisioner.repository }}:{{ .Values.image.csiProvisioner.tag }}" | ||
| args: | ||
| - --provisioner=disk.csi.azure.com | ||
| - --csi-address=$(ADDRESS) | ||
| - --timeout=120s | ||
| - --retry-interval-start=1s | ||
| - --retry-interval-max=5m | ||
| - --worker-threads=100 | ||
|
|
@@ -32,6 +33,7 @@ spec: | |
| {{- end}} | ||
| - --enable-leader-election | ||
| - --leader-election-type=leases | ||
| - --v=5 | ||
| env: | ||
| - name: ADDRESS | ||
| value: /csi/csi.sock | ||
|
|
@@ -40,14 +42,16 @@ spec: | |
| - mountPath: /csi | ||
| name: socket-dir | ||
| - name: csi-attacher | ||
| image: "{{ .Values.image.csiAttacher.repository }}:{{ .Values.image.csiAttacher.tag }}" | ||
| args: | ||
| - --v=5 | ||
| - --csi-address=$(ADDRESS) | ||
| - --timeout=120s | ||
| - --retry-interval-start=1s | ||
| - --retry-interval-max=5m | ||
| - --worker-threads=20 | ||
| - -leader-election | ||
| - -leader-election-type=leases | ||
| env: | ||
| - name: ADDRESS | ||
| value: /csi/csi.sock | ||
|
|
@@ -56,7 +60,7 @@ spec: | |
| - mountPath: /csi | ||
| name: socket-dir | ||
| - name: cluster-driver-registrar | ||
| image: "{{ .Values.image.clusterDriverRegistrar.repository }}:{{ .Values.image.clusterDriverRegistrar.tag }}" | ||
| args: | ||
| - --csi-address=$(ADDRESS) | ||
| - --driver-requires-attachment=true | ||
|
|
@@ -68,17 +72,30 @@ spec: | |
| - name: socket-dir | ||
| mountPath: /csi | ||
| - name: csi-snapshotter | ||
| image: "{{ .Values.image.csiSnapshotter.repository }}:{{ .Values.image.csiSnapshotter.tag }}" | ||
| args: | ||
| - --csi-address=$(ADDRESS) | ||
| - -leader-election | ||
|
There was a problem hiding this comment. doesn't it need to be double-dash ? There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade There was a problem hiding this comment. I will ignore the inconsistency of the also in upstream existing arguments 🤣 ... for now 😉 |
||
| env: | ||
| - name: ADDRESS | ||
| value: /csi/csi.sock | ||
| volumeMounts: | ||
| - name: socket-dir | ||
| mountPath: /csi | ||
| - name: csi-resizer | ||
| image: "{{ .Values.image.csiResizer.repository }}:{{ .Values.image.csiResizer.tag }}" | ||
| args: | ||
| - -csi-address=$(ADDRESS) | ||
|
There was a problem hiding this comment. doesn't it need to be double-dash ? There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade There was a problem hiding this comment. I will ignore the inconsistency of the also in upstream existing arguments 🤣 ... for now 😉 |
||
| - -v=5 | ||
| - -leader-election | ||
| env: | ||
| - name: ADDRESS | ||
| value: /csi/csi.sock | ||
| volumeMounts: | ||
| - name: socket-dir | ||
| mountPath: /csi | ||
| - name: liveness-probe | ||
| image: "{{ .Values.image.livenessProbe.repository }}:{{ .Values.image.livenessProbe.tag }}" | ||
| args: | ||
| - --csi-address=/csi/csi.sock | ||
| - --connection-timeout=3s | ||
|
|
@@ -87,11 +104,11 @@ spec: | |
| - name: socket-dir | ||
| mountPath: /csi | ||
| - name: azuredisk | ||
hectorj2f marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| image: "{{ .Values.image.azuredisk.repository }}:{{ .Values.image.azuredisk.tag }}" | ||
| args: | ||
| - --v=5 | ||
| - --endpoint=$(CSI_ENDPOINT) | ||
| - --nodeid=$(KUBE_NODE_NAME) | ||
| ports: | ||
| - containerPort: 9602 | ||
| name: healthz | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,57 @@ | ||
| image: | ||
| azuredisk: | ||
| repository: mcr.microsoft.com/k8s/csi/azuredisk-csi | ||
| tag: v0.5.0 | ||
| pullPolicy: Always | ||
| csiProvisioner: | ||
hectorj2f marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| repository: quay.io/k8scsi/csi-provisioner | ||
| tag: v1.4.0 | ||
|
There was a problem hiding this comment. v1.5.0 got released, but maybe something for the next change There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade |
||
| pullPolicy: Always | ||
| csiAttacher: | ||
| repository: quay.io/k8scsi/csi-attacher | ||
| tag: v1.2.0 | ||
|
There was a problem hiding this comment. v2.1.1 got released, but maybe something for the next change There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade There was a problem hiding this comment. I am aware is using this specific versions, but that is what we believe it is being tested so... that is what we should use There was a problem hiding this comment.
well actually I decline, especially if I see bugs popping up in kubernetes version related to the |
||
| pullPolicy: Always | ||
| clusterDriverRegistrar: | ||
| repository: quay.io/k8scsi/csi-cluster-driver-registrar | ||
| tag: v1.0.1 | ||
| pullPolicy: Always | ||
| csiSnapshotter: | ||
| repository: quay.io/k8scsi/csi-snapshotter | ||
| tag: v1.1.0 | ||
|
There was a problem hiding this comment. v2.0.1 got released, but maybe something for the next change There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade |
||
| pullPolicy: Always | ||
| csiResizer: | ||
| repository: quay.io/k8scsi/csi-resizer | ||
| tag: v0.3.0 | ||
|
There was a problem hiding this comment. v0.4.0 got released, but maybe something for the next change There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade |
||
| pullPolicy: Always | ||
| livenessProbe: | ||
| repository: quay.io/k8scsi/livenessprobe | ||
| tag: v1.1.0 | ||
|
There was a problem hiding this comment. v2.0.0 got released, but maybe something for the next change There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade |
||
| pullPolicy: Always | ||
| nodeDriverRegistrar: | ||
| repository: quay.io/k8scsi/csi-node-driver-registrar | ||
| tag: v1.1.0 | ||
|
There was a problem hiding this comment. v1.2.0 got released, but maybe something for the next change There was a problem hiding this comment. look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade |
||
| pullPolicy: Always | ||
|
|
||
| serviceAccount: | ||
| create: true | ||
|
|
||
| rbac: | ||
| create: true | ||
|
|
||
| controller: | ||
| replicas: 3 | ||
|
|
||
| # True if enable volume scheduling for dynamic volume provisioning | ||
| enableVolumeScheduling: false | ||
|
|
||
| cloudConfig: /etc/kubernetes/cloud-config/cloud.conf | ||
|
|
||
| azuredisk: | ||
| node: | ||
| tolerations: | ||
| - effect: NoSchedule | ||
| operator: Exists | ||
| - effect: NoExecute | ||
| operator: Exists | ||
| - key: CriticalAddonsOnly | ||
| operator: Exists | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't it need to be double-dash ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at https://github.com/kubernetes-sigs/azuredisk-csi-driver for the next upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will ignore the inconsistency of the also in upstream existing arguments 🤣 ... for now 😉