Upgrade prometheus-operator to 8.3.3 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branden
force-pushed
the
prom-upgrade
branch
from
52e6d8c to
e03b2c1
Compare
This was referenced Dec 11, 2019
branden
requested review from
alejandroEsc,
gracedo,
philipnrmn,
hectorj2f and
jimmidyson
|
@branden I am not sure that fixes the kube-state-metrics issue. But I will test all the changes in this PR and let you know |
hectorj2f
approved these changes
Dec 12, 2019
|
I checked and tested all the graphs with 1.16 and 1.15, I didn't see any errors in the logs and the graphs have datapoints for those missing in the previous version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mesosphere.com/browse/DCOS-60484
https://jira.mesosphere.com/browse/DCOS-61841
This PR upgrades this repo's fork of prometheus-operator to the latest upstream version, while keeping local modifications intact.
Note that this PR removes the copies of prometheus-operator's subcharts under
staging/prometheus-operator/dependent-charts. We now reference the official upstream versions of these charts.This PR requires changes to the Prometheus addon. See mesosphere-backup/kubeaddons-configs#368.
Testing
I tested this PR by launching a Konvoy 1.3.0-beta7 cluster with the
configVersionset tobranden/prom-upgrade-kommander-beta7, which is a branch of kubeaddons-configs based on kommander-beta7 that I've modified to deploy the prometheus-operator chart from this PR.I verified that prometheus-operator deploys successfully, then looked at all Grafana dashboards and observed that they display metrics. I verified that our custom dashboards are present and displaying metrics. I looked at the Alertmanager dashboard and observed that its watchdog alert is present.