Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch: use apps/v1 api #275

Merged
merged 1 commit into from
Nov 20, 2019
Merged

dispatch: use apps/v1 api #275

merged 1 commit into from
Nov 20, 2019

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Nov 20, 2019

Part of https://jira.mesosphere.com/browse/DCOS-61056

Needed for Kubernetes v1.16.

@dkoshkin dkoshkin added the ready ready label Nov 20, 2019
@dkoshkin dkoshkin requested review from gpaul and joejulian November 20, 2019 19:13
@dkoshkin dkoshkin self-assigned this Nov 20, 2019
@dkoshkin
Copy link
Contributor Author

Good catch CI :)

Signed-off-by: Dimitri Koshkin <[email protected]>
Copy link
Contributor

@gpaul gpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jbarrick-mesosphere ^ ?

@oliviabarrick
Copy link

We need to be careful about making changes here. They’ll get overwritten next time we update the chart from our repository.

@dkoshkin
Copy link
Contributor Author

@justinbarrick I didn't realize you had the chart in a different repo, will PR the same change there.

@dkoshkin dkoshkin merged commit dd139fe into dev Nov 20, 2019
@dkoshkin dkoshkin deleted the dkoshkin/dispatch branch November 20, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants