Allow periods in job names #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking forward to this! |
|
How about /? |
|
shipit FWIW @felixb I am in favor of allowing / and a bunch of other standard ascii separator characters but I have no idea if there are constraints the Chronos authors were trying to follow when they decided this regex (and I don't see any comments about it in JobUtils.scala). Maybe one of them will chime in :) |
|
Looks great, thanks! |
brndnmtthws
added a commit
that referenced
this pull request
Sep 10, 2015
Allow periods in job names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marathon allows periods in job names, but Chronos rejects jobs with periods in their names. Periods are useful as a delimiter, and there's no obvious reason why they aren't allowed in job names. I updated the regex to allow periods and added a test to check that the job name validation accepts a job name containing periods.
Tests ran and passed.