Add glbinding #974
Add glbinding #974
Conversation
v1993
force-pushed
the
glbinding
branch
2 times, most recently
from
e12dcdb to
b6f9610
Compare
|
Checks keep failing due to unauthorized files, even though I've added them to script as exceptions. I guess CI runs script from master branch instead of PR? Also, MSVC emits a truly ridiculous amount of warning C4251, but it doesn't seem to be our fault. |
v1993
force-pushed
the
glbinding
branch
4 times, most recently
from
a48bd0f to
1c1765e
Compare
v1993
force-pushed
the
glbinding
branch
4 times, most recently
from
a10aae2 to
abbf4f6
Compare
|
The entries in sanity_checks.py need to have the subdir. |
Does it? None of existing entries include subdirectory and some of them (e.g. box2d) have files stored in one. EDIT: Figured it out, I forgot commas... so much for implicit concatenation! |
|
@neheb Test suite is passing now. This should be ready to merge. |
|
Fixed issues pointed out by review. |
v1993
force-pushed
the
glbinding
branch
2 times, most recently
from
e6b5adc to
355973c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
v1993
force-pushed
the
glbinding
branch
2 times, most recently
from
b7f4b20 to
52408bb
Compare
| @@ -0,0 +1 @@ | |||
| #include <glbinding/Binding.h> | |||
There was a problem hiding this comment.
About this file...
Upstream has its own precompiled header - which is why I've decided to make use of this feature in the first place. However, that header is included by other files (which meson docs warns not to do, although it doesn't seem to break in practice) and has a #pragma once guard, which produces a compiler warning.
As for build time - there's a clear benefit, reducing it from ~47 seconds to ~36 seconds on my machine.
|
Please rebase to current master |
So, what now? |
|
I’d squash some of these commits. That’s a hilarious error. Wonder if it can be worked around. |
v1993
force-pushed
the
glbinding
branch
3 times, most recently
from
cb8d475 to
b42af69
Compare
Upstream relies on CMake-generated headers that are far too complex to reproduce nicely with meson, so I've bundled them and tweaked where needed.
This is useful when accounting for system-wide installation, since that has both libraries as CMake targets:
```
glbinding = dependency('glbinding', method: 'cmake', modules: ['glbinding::glbinding', 'glbinding::glbinding-aux'], default_options: ['main_glbinding_includes_aux=true'])
```
By default, tests are compiled but not run. This is because they don't work in headless environment like CI.
|
Looks like tests have succeeded on MSYS2-UCRT64 by sheer luck this time. I haven't changed anything significant, only rearranged changes around commits. If anyone is curious, here's the most likely monstrosity of a file causing compiler to run out of memory. |
|
That is indeed a monstrosity. Cool that it works now. |
Add https://github.com/cginternals/glbinding - a C++ OpenGL binding/loader with enhanced type safety. Includes glbinding-aux library, which is not built by default.
Upstream relies on CMake-generated headers that are far too complex to reproduce nicely with meson, so I've bundled them and tweaked where needed.
I'm not quite sure about tests - it's an OpenGL library, so I doubt CI will manage to run them.