Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas: improvements to 0.3.28 patch files #1815

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

rgommers
Copy link
Contributor

@rgommers rgommers commented Dec 9, 2024

These changes are what I needed to use an openblas subproject with SciPy. A few bits of minor maintenance (de-duplicating configure checks, silencing build warnings, fixing some typos), and a few bugs that were caught by the SciPy test suite, which is quite a bit more extensive than OpenBLAS's own tests.

Follows up on gh-1734.

Cc @HaoZeke for visibility.

@rgommers
Copy link
Contributor Author

I was confused for a moment about why Alpine is failing here while it was passing on gh-1734 - in addition to the Windows builds, which were failing there already. The reason is that the build configs have changed: the Alpine job in gh-1734 was using x86-64, while now there are four Alpine configs for x64, riscv64, ppc64le, armv7. The SIMD kernels for those platforms are not wired up at all, this wrap only supports x86-64 and arm64 right now. I'll update to emit a more informative error at the start of the build.

Other than that, can I just ignore the Alpine failure (for the reason as given in #1734 (comment)) @eli-schwartz?

@eli-schwartz
Copy link
Member

Yes -- please do ignore and defer those new errors to be addressed at some future date.

@rgommers
Copy link
Contributor Author

Thanks. This should be good to go then. It passes the relevant CI jobs here, as well as the ones on @HaoZeke's repo (HaoZeke/OpenBLAS#30), and the SciPy test suite in my local testing.

Copy link
Contributor

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rgommers

@jpakkane jpakkane merged commit a5fdfe2 into mesonbuild:master Dec 11, 2024
4 of 12 checks passed
@rgommers rgommers deleted the openblas-update branch December 11, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants