-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openblas: improvements to 0.3.28 patch files #1815
Conversation
6d8c0f2
to
0cc1694
Compare
0cc1694
to
a1d842f
Compare
subprojects/packagefiles/openblas/lapack-netlib/BLAS/SRC/meson.build
Outdated
Show resolved
Hide resolved
a1d842f
to
ef9826f
Compare
I was confused for a moment about why Alpine is failing here while it was passing on gh-1734 - in addition to the Windows builds, which were failing there already. The reason is that the build configs have changed: the Alpine job in gh-1734 was using x86-64, while now there are four Alpine configs for x64, riscv64, ppc64le, armv7. The SIMD kernels for those platforms are not wired up at all, this wrap only supports x86-64 and arm64 right now. I'll update to emit a more informative error at the start of the build. Other than that, can I just ignore the Alpine failure (for the reason as given in #1734 (comment)) @eli-schwartz? |
ef9826f
to
e86e43f
Compare
Yes -- please do ignore and defer those new errors to be addressed at some future date. |
Thanks. This should be good to go then. It passes the relevant CI jobs here, as well as the ones on @HaoZeke's repo (HaoZeke/OpenBLAS#30), and the SciPy test suite in my local testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgommers
These changes are what I needed to use an
openblas
subproject with SciPy. A few bits of minor maintenance (de-duplicating configure checks, silencing build warnings, fixing some typos), and a few bugs that were caught by the SciPy test suite, which is quite a bit more extensive than OpenBLAS's own tests.Follows up on gh-1734.
Cc @HaoZeke for visibility.