-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: add 8.0.1 #1149
curl: add 8.0.1 #1149
Conversation
You mean 2023 or it had no release in 10 years? |
2023, of course… |
so a bunch of packages are not set to be built on MSVC because of missing curl. Would be interesting to undo that and see if they build. |
Those packages would need an explicit |
well, this PR provides it. |
Oh, right, the superproject provides it. |
So let's say I want to test if |
In order to get it tested in this PR, yes. A commit like that can be removed prior to merging. |
'c', | ||
version: '8.0.1', | ||
# Version gated use of `test(…, verbose: true)` needs `0.62.0`. | ||
meson_version: meson.version().version_compare('>=0.62.0') ? '>=0.62.0' : '>=0.60.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is...fascinating. I remember doing something like this with an older meson version and got an error. Can't remember which it was. I'd just set to 0.62.0 personally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, why is verbose: true even needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole curl testsuite is run by tests/runtests.pl
, so from meson's point of view, there's only one test. And said test can take a while, so verbose output is a much nicer default.
|
||
_headerlist = { | ||
'arpa/inet.h': [ | ||
'getpeername', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is so hard to read. Maybe put the array on the same line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easier as soon as they are multiple functions, and muon fmt
will automatically switch to multiple-lines in that case anyway. I try to limit my fighting with its choices.
I'd remove liblastfm from the test commit. It's known broken on Windows. I need to fix it at some point. |
Looks like the libupnp build is broken with msvc too. |
849b4ef
to
d940f00
Compare
ah right. libupnp needs some special threading library that I never bothered with. |
14552de
to
3556843
Compare
3556843
to
378b6b7
Compare
first casualty:
The problem here is that libmicrohttpd defines it as ptrdiff_t whereas this defines it as __int64. Should be the former I think. |
|
Note:
>= 2.4.48
(2019) and Windows.Close #561.